Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the same domain to multiple designated containers #1887

Closed
lieryan opened this issue Oct 9, 2020 · 8 comments
Closed

Add the same domain to multiple designated containers #1887

lieryan opened this issue Oct 9, 2020 · 8 comments

Comments

@lieryan
Copy link

lieryan commented Oct 9, 2020

The "Limit to Designated Sites" option is a great option, but enabling this causes problems if you have multiple containers that shares the sa
me Single Sign On (SSO) domain.

Currently, I want to have Container A to only ever run Site A1, A2, A3, and Container B to only ever run Site B1, B2, B3, so I have "Limit to Designated Sites" option turned on for these containers. However, Site A1 and B1 needs to occasionally redirect to Site S, for example, to do a SSO login. Currently, you can only assign a single domain to a single container, which means that if you add Site S to Container A, then add it again to Container B, then Site A1 can no longer redirect for login correctly to Site C.

@ghost
Copy link

ghost commented Oct 21, 2020

Seconded as I use multiple containers for the same site (with different accounts) and this feature would be very helpful for me.

@wfaulk-bw
Copy link

Can you not just leave Site S unassigned? That way when Site A redirects there, it stays in Container A, and when Site B redirects there, it stays in Container B.

@tmottabr
Copy link

tmottabr commented Apr 20, 2021

Can you not just leave Site S unassigned? That way when Site A redirects there, it stays in Container A, and when Site B redirects there, it stays in Container B.

not if in one of the containers you want to enable "limit to designated sites" as well so links to external sites do not open in that same container..

If you do that it cannot open the site in that container at all if the site is not assigned to that container.

And if you assign it to that container you cannot open it in any another container as it get locked to that container it is assigned to.

basically what we need is either decouple the configuration of what sites will be forced to open in a given container to the list of sites that a container should be limited to.

Or allow the same site to be linked to two separated containers.

my problem is exactly this, i have a site i have two accounts but i want to have the two containers i use for this site configured with "limited to designated sites", but currently i cannot because i can only link the domain to one container and if i do i cannot open it in the other.

@tmottabr
Copy link

some people also mentioned the SSO problem, where your authentication is performed by an third-party.

You might have two containers that you want to limit to designated sites but both sites authenticate with the same SSO provider.

If enable designated sites you cannot authenticate in the container that have it enabled and if you assign the SSO provider to one container you cannot authenticate in the other.

@ncallaway
Copy link

I think this is essentially the same request as #1892.

I've started working on a PR for this feature, and have a working proof of concept. I need to do a bit of cleaning up, so I expect to have a PR out by next weekend.

ncallaway added a commit to ncallaway/multi-account-containers that referenced this issue Apr 25, 2021
This implements a per-container allow-list that is applied to isolated
containers. This can allow multiple containers to have an overlapping set of
sites that they are isolated to.

For example: Container A and Container B could both be isolated and have
calendar.example.com in their allow list. Both Container A and Container B
would then be able to visit calendar.example.com.

See: mozilla#1892 and
mozilla#1887 for additional
motivation.
ncallaway added a commit to ncallaway/multi-account-containers that referenced this issue Apr 25, 2021
This implements a per-container allow-list that is applied to isolated
containers. This can allow multiple containers to have an overlapping set of
sites that they are isolated to.

For example: Container A and Container B could both be isolated and have
calendar.example.com in their allow list. Both Container A and Container B
would then be able to visit calendar.example.com.

See: mozilla#1892 and
mozilla#1887 for additional
motivation.
@ncallaway
Copy link

Draft PR is out here: #2033. Remaining work is just the new icon and any PR feedback, which I'll work on this week.

@ncallaway
Copy link

The related PR is now ready for review.

@dannycolin
Copy link
Collaborator

Duplicate of #1749

@dannycolin dannycolin marked this as a duplicate of #1749 Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants