Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hsts-preloaded not taken into account #456

Open
mktl73 opened this issue Nov 15, 2021 · 7 comments
Open

hsts-preloaded not taken into account #456

mktl73 opened this issue Nov 15, 2021 · 7 comments

Comments

@mktl73
Copy link

mktl73 commented Nov 15, 2021

I see in the scoring methodology that sites that are "Preloaded via the HTTP Strict Transport Security (HSTS) preloading process" get an additional 5 points. We have several domains that are preloaded though we never get the +5 score

Example:
https://observatory.mozilla.org/analyze/www.skybrary.aero
https://hstspreload.org/?domain=skybrary.aero

Is this me missing something or is there an issue in the scoring.
Thanks

@GreyXor
Copy link

GreyXor commented Nov 25, 2021

Hello @mktl73,

The list of sites that are hsts-preloaded is locally loaded file. It is a useful cache system but it can cause the data to be out of date. I suspect that your problem is due to this list has not been updated on the back-end.

Hello @april , It seems to me that historically it is you who updates this file ? Maybe you can update the list on your side ? I can help you set up a process to update the list on a recurring basis, if needed :)

@april
Copy link
Contributor

april commented Nov 25, 2021

I submitted a PR to update the HSTS list, but the tests haven't been updated to work with GitHub actions:

#457

So I'll let @gene1wood take a look at that and either merge or fix the tests first and then merge.

Thanks!

@GreyXor
Copy link

GreyXor commented Nov 25, 2021

Thanks @april for the quick feedback!

@mktl73
Copy link
Author

mktl73 commented Nov 25, 2021

Thanks @april and @GreyXor for the actions.

@gene1wood
Copy link
Member

I've merged the PR, thank you for it April

tests haven't been updated to work with GitHub actions

@april Is there an issue on this or if not can you share more detail on what needs to be done in regards to tests and GitHub Actions?

@april
Copy link
Contributor

april commented Dec 6, 2021

I don't think there's an issue on this. It should be relatively easy though - look at the travis.yml file and make that work in GA. Basically you run pip install and then nosetests and a linter. :)

@gene1wood
Copy link
Member

@april I've opened #458 to switch to GitHub Actions, if you feel like taking a glance at it, I can merge it if it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants