Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't penalize disabled X-XSS-PROTECTION #432

Open
franziskuskiefer opened this issue Sep 14, 2020 · 7 comments
Open

Don't penalize disabled X-XSS-PROTECTION #432

franziskuskiefer opened this issue Sep 14, 2020 · 7 comments

Comments

@franziskuskiefer
Copy link

The X-XSS-PROTECTION header is pretty much unused now [1][2]. The observatory shouldn't penalize websites for X-XSS-PROTECTION=0.

image

[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection
[2] helmetjs/helmet#230

@emilbjorklund
Copy link

The X-XSS-Protection header is now considered deprecated by the OWASP Secure Headers project, and the recommended setting is 0 - please consider not penalizing sites for following that guideline.

Warning: The X-XSS-Protection header has been deprecated by modern browsers and its use can introduce additional security issues on the client side. As such, it is recommended to set the header as X-XSS-Protection: 0 in order to disable the XSS Auditor, and not allow it to take the default behavior of the browser handling the response. Please use Content-Security-Policy instead.

Source:
https://owasp.org/www-project-secure-headers/#x-xss-protection

@Seirdy
Copy link

Seirdy commented Jun 30, 2021

More on the holes opened by enabling X-XSS-Protection: it was successfully used to exploit a vulnerability in Facebook after which FB set X-XSS-Protection to 0.

@vladimir-kazakov
Copy link

This header is also considered to be non-standard, since it's not supported in the majority of modern web browsers.

@ZeikoFr
Copy link

ZeikoFr commented Sep 8, 2022

Hi,

Any news on this issue ?

I will try to look into the code somewhere in the next few weeks but I'm not a dev so any help is appriciated

Regards

@haleybe
Copy link

haleybe commented Aug 20, 2023

Still waiting on this?

@sbernard31
Copy link

When you set : X-XSS-Protection 0, you get :
Capture d’écran du 2024-01-08 16-11-10

And when you click on X-XSS-Protection link :
You can read :

In modern browsers, X-XSS-Protection has been deprecated in favor of the Content-Security-Policy to disable the use of inline JavaScript. Its use can introduce XSS vulnerabilities in otherwise safe websites. This should not be used unless you need to support older web browsers that don’t yet support CSP. It is thus recommended to set the header as X-XSS-Protection: 0.

🤯

@janbrasna
Copy link

Fixed in #520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants