Skip to content
This repository has been archived by the owner on Jan 29, 2019. It is now read-only.

Document how to add a DTL template engine for 1.8 sites #283

Open
Osmose opened this issue Apr 6, 2015 · 4 comments
Open

Document how to add a DTL template engine for 1.8 sites #283

Osmose opened this issue Apr 6, 2015 · 4 comments

Comments

@Osmose
Copy link
Contributor

Osmose commented Apr 6, 2015

If a site is using Django 1.8 and does not have any TEMPLATES engine definition for Django templates (if they're using Jinja or something else instead), they'll need to add an extra engine definition specifically for our library if they want to use our helpers. We should document something to that effect.

(I have yet to actually get around to testing this, so I might be getting the details of the problem wrong.)

@Osmose
Copy link
Contributor Author

Osmose commented Apr 6, 2015

Alternatively, maybe we can just provide Jinja2 templates and wait until someone complains that we don't support their custom template syntax.

@abompard
Copy link
Contributor

The Django 1.8 documentation is not very clear yet on how libraries should handle custom template engines. In the meantime, the code in git now works with the DTL, and the currently released code does not work with Django 1.8 at all.
Would it be possible to cut a release with what we have now? My webapp uses django-browserid and I currently have to force users to use Django 1.7.

@Osmose
Copy link
Contributor Author

Osmose commented Apr 29, 2015

I'm hoping to cut a release after #289 gets merged (I wrote it in response to one of my projects using Django 1.8 and django-jinja and failing when I updated django-browserid), and then land some documentation updates.

@Osmose
Copy link
Contributor Author

Osmose commented Apr 30, 2015

@abompard FYI 1.0.0 is released with the Django 1.8 fixes. https://github.com/mozilla/django-browserid/releases/tag/v1.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants