Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When revision is "latest", get the source code from the revision of the last successful coverage run rather than "tip" #525

Open
gijsk opened this issue May 18, 2020 · 3 comments

Comments

@gijsk
Copy link

gijsk commented May 18, 2020

(potentially related: #524 )

When looking at https://coverage.moz.tools/#revision=latest&path=browser%2Fbase%2Fcontent%2Fbrowser.js&view=file&line=7938 (actually around line 7938!) there are some commented lines that are apparently "covered", some code lines that are "non-instrumented", and some method signatures labeled "uncovered" while their contents are "covered".

This makes me suspect the line numbers in the coverage data are off somehow.

@gijsk
Copy link
Author

gijsk commented May 18, 2020

@marco-c points out that this used to be correct: https://coverage.moz.tools/#revision=d24d00b719aa&path=browser%2Fbase%2Fcontent%2Fbrowser.js&view=file shows reasonable data.

@marco-c
Copy link
Collaborator

marco-c commented May 18, 2020

The issue was that for a couple of days the coverage generation was broken, and when using revision=latest we are getting the code from "tip" but the coverage from the latest successful coverage run.

@marco-c marco-c changed the title Per-line JS coverage data seems confused about where lines are When revision is "latest", get the source code from the revision of the last successful coverage run rather than "tip" May 18, 2020
@marco-c
Copy link
Collaborator

marco-c commented May 18, 2020

The pressing issue is now fixed, so the coverage no longer looks weird.
It's still worth fixing this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants