Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force all users to a given node ID #1523

Closed
data-sync-user opened this issue Feb 27, 2024 · 3 comments
Closed

Force all users to a given node ID #1523

data-sync-user opened this issue Feb 27, 2024 · 3 comments
Assignees

Comments

@data-sync-user
Copy link
Collaborator

We have some users still reporting that they’re on AWS nodes. We should force all users to go to the Spanner node.

┆Issue is synchronized with this Jira Task

@jrconlin
Copy link
Member

This is already being done by setting SYNC_TOKENSERVER__SPANNER_NODE_ID.

@jrconlin jrconlin reopened this Feb 28, 2024
@jrconlin
Copy link
Member

I am hot sure, but I believe there may be an edge case where a user record may not be properly migrated.
tokenserver::handlers::update_user(..) only migrates the user via db.post_user(..) if the req.auth_data.client_state (from the auth token) does not match the req.user.client_state (from the stored user record). (The later generation check does not alter the node_id.)

I have no idea how the user could end up in this state, and it presumes that the auth token has not changed, but we should check the user's previous node_id to see if it matches the spanner_node_id and force an update if it does not.

@data-sync-user
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants