Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify write_results method to accept a path #155

Open
kimberlythegeek opened this issue Oct 24, 2018 · 2 comments
Open

Modify write_results method to accept a path #155

kimberlythegeek opened this issue Oct 24, 2018 · 2 comments
Labels
in progress

Comments

@kimberlythegeek
Copy link
Contributor

Originally posted by @davehunt in #151
@kimberlythegeek
Copy link
Contributor Author

davehunt a day ago Member

This hard-codes writing the file to the current working directory. Could there be a reason to want to write the file elsewhere? If so, it might make sense for write_results to take a path. Then the user can decide if they want it to be relative, or absolute, and can decide the destination. You could still default to current working directory if only a file name is provided, but you'd also need to handle when the destination does not exist. You can see an example of this in pytest-html https://github.com/pytest-dev/pytest-html/blob/master/pytest_html/plugin.py#L89-L90

@terrameijar
Copy link
Contributor

Hi @kimberlythegeek I would like to work on this.

@terrameijar terrameijar mentioned this issue Oct 26, 2018
Merged
kimberlythegeek pushed a commit that referenced this issue Nov 5, 2018
@terrameijar
Fix for #155 (#157)
e85ea45 
* Allows write_results to take a path

* fixed pep8 issues

* Fixed default arguments and updated path handling logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terrameijar @kimberlythegeek