Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize BigtableClientImpl pooling #692

Open
data-sync-user opened this issue Apr 22, 2024 · 0 comments
Open

Optimize BigtableClientImpl pooling #692

data-sync-user opened this issue Apr 22, 2024 · 0 comments

Comments

@data-sync-user
Copy link
Collaborator

As part of https://github.com/mozilla-services/autopush-rs/commit/2fd708654e92838953d030274bbf3de52b45f7d0 I decided to construct the Pool to contain BigtableDb, which is owned and managed by us. While this works, it may be more efficient to pool the grpcio::Channel tjat BigtableClientuses. Neither Channel nor BigtableClient are owned by us, so they’re subject to change, however there is a BigtableClient::new(channel) function which we might be able to use to create the client. Ensuring that the channel is available to extract, however, might be trickier.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant