Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the autopush crate #524

Closed
data-sync-user opened this issue Nov 28, 2023 · 2 comments
Closed

Remove the autopush crate #524

data-sync-user opened this issue Nov 28, 2023 · 2 comments
Assignees

Comments

@data-sync-user
Copy link
Collaborator

At some point we can remove the autopush crate entirely from the repo, probably earliest some time in Q1 '24.

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator Author

➤ Philip Jenvey commented:

To fully cleanup the all artifacts when removing this crate:

  • Most of the dependencies solely used by the legacy autopush crate should solely have entries in its Cargo.toml, but there’s likely also some in the root Cargo.toml file. There’s a few different ways to detect these – there should be a pass done to remove them
  • This crate’s responsible for likely most if not all of our cargo audit ignores. So all the ignores in .cargo/audit.toml should be removed, then cargo audit should be ran again to see if any advisories still need to continue being ignored

@taddes taddes self-assigned this May 6, 2024
@data-sync-user
Copy link
Collaborator Author

➤ Taddes Korris commented:

Just noting a few things:

  • Ran cargo machete to check on unused deps in parent/root Cargo.toml. Did a little reviewing and regex searches too. In the end, it was quite clean and most of the deps pertaining to the autopush crate were unique to its own Cargo.toml.
  • Ref to module in integration tests removed
  • A handful of audit messages were removed. Those that remain do pertain to other dependencies in the workspace. I renamed one that related to tungstenite that was tokio-tungstenite in the autopush crate. However, tungstenite in the parent crate is set to older ver (Note from Cargo.toml: Use older version of tungstenite to support legacy connection server.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants