Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on main started failing, but HEAD originally passed #822

Open
2 of 3 tasks
hwine opened this issue Mar 24, 2022 · 3 comments
Open
2 of 3 tasks

CI on main started failing, but HEAD originally passed #822

hwine opened this issue Mar 24, 2022 · 3 comments
Assignees
Labels
bug code quality code improvements and tidiness in progress

Comments

@hwine
Copy link
Contributor

hwine commented Mar 24, 2022

So this is an issue with the CI pipeline. Timeline in comment

To Do:

  • compare messages, 1st failure to latest failure
  • verify assumption that there is no code impact
  • apply changes

[tracked internally as ITSEC-211]

@hwine hwine added bug in progress code quality code improvements and tidiness labels Mar 24, 2022
@hwine hwine self-assigned this Mar 24, 2022
@hwine
Copy link
Contributor Author

hwine commented Mar 24, 2022

Date Status Notes
2021-11-30 passing latest commit to main @0b2dced
2021-11-30 ERROR unit tests failed to retrieve docker image from AWS
2021-12-02 passing last successful run
2021-12-03 ERROR unit test & lint-vet-fmt both missing needed testing modules missing from go test & go vet;
time passes ERROR no change - all runs Failing, assuming for same test ERROR as above
2022-03-23 ERROR latest test, same fails as above (failures brought to our attention)

@ajvb
Copy link
Contributor

ajvb commented Mar 24, 2022

So, on 2021-12-02, go 1.16.11 was released - https://go.dev/doc/devel/release#go1.16.minor

I imagine this is what introduced the problem. I tried pinning to 1.16.10 in https://github.com/mozilla-services/autograph/compare/ajvb/fix-circle?expand=1 but that didn't seem to fix it. Will look into it further. I'm guessing it's something silly with Circle.

I also tried just upgrading straight to go 1.17, which does solve this issue, but breaks a few tests. Might be worth doing that upgrade instead, but need to fight with circle a bit more first.

@hwine
Copy link
Contributor Author

hwine commented Mar 24, 2022

So, on 2021-12-02, go 1.16.11 was released - https://go.dev/doc/devel/release#go1.16.minor

well, there we "go" 😏 Thanks for looking into this!

I also tried just upgrading straight to go 1.17, which does solve this issue, but breaks a few tests. Might be worth doing that upgrade instead, but need to fight with circle a bit more first.

You leaving the app on 1.16.10, and just moving the tests to 1.17, right? Or moving the whole project to 1.17?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code quality code improvements and tidiness in progress
Projects
None yet
Development

No branches or pull requests

2 participants