Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seleniumable element classes/ids. #21

Open
mcav opened this issue Jan 26, 2017 · 1 comment
Open

Add seleniumable element classes/ids. #21

mcav opened this issue Jan 26, 2017 · 1 comment
Labels

Comments

@mcav
Copy link
Contributor

mcav commented Jan 26, 2017

As noted in #19, we don't have any useful selectors for testing. This is largely due to styled-components, which hashes CSS class names for various reasons. We should add class names, or maybe just IDs, to all user-touchable components, so that we can write tests without going batshit crazy. :)

@mcav mcav mentioned this issue Jan 26, 2017
@isabelrios
Copy link
Collaborator

isabelrios commented Jan 26, 2017

Thanks for the explanation! So far it is not difficult to find the xpath or css selector for each element, the problem is that they do not look nice and the tests need a lot of maintenance as the xpath/selector changes while developing the website.
#19 has been closed since a new version of the tests is being developed following the PO pattern.
That new version will have temporary selectors till having the class names or ids, it would be easier to change to the final ones since the selectors are defined in one place, but at least in the meantime will allow QA to work on the skeleton and coverage of the tests.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants