Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests simplification: use promises, generators and template strings #59

Open
julienw opened this issue Jan 19, 2017 · 0 comments
Open

Tests simplification: use promises, generators and template strings #59

julienw opened this issue Jan 19, 2017 · 0 comments
Labels
enhancement good first bug help wanted testing
Milestone
Next

Comments

@julienw
Copy link
Collaborator

julienw commented Jan 19, 2017

In many tests (eg test_auth_api.js) we have:

  • string concatenation
  • callback-based tests (with mocha's done)
  • asynchronous code using promises or (worse !) callbacks

We can make them more readable using (respectively) template strings, promises and generators (using co-mocha).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first bug help wanted testing
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@julienw @ferjm