Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chrome support for social media activity #331

Closed
wants to merge 5 commits into from

Conversation

rhelmer
Copy link
Contributor

@rhelmer rhelmer commented Oct 11, 2022

Fixes #330

@rhelmer rhelmer force-pushed the add-chrome-support-for-socialMediaActivity branch from 0230128 to 13041d1 Compare October 11, 2022 02:18
@rhelmer
Copy link
Contributor Author

rhelmer commented Oct 11, 2022

I think we'll need to manually test this, I suggest we make very minimal test cases for the automated tests, since they are liable to break (especially the cases where internal page details and not APIs are used), we'll want to make them easy to adjust.

It looks like these modules don't currently support unloading their content scripts when listeners are removed, I'll file a followup issue to add that later.

@rhelmer rhelmer requested a review from aaga October 11, 2022 02:23
@rhelmer rhelmer closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port socialMediaActivity to Chrome and add tests
1 participant