Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable stricter eslint rules #32

Open
rhelmer opened this issue Mar 30, 2021 · 3 comments
Open

enable stricter eslint rules #32

rhelmer opened this issue Mar 30, 2021 · 3 comments

Comments

@rhelmer
Copy link
Contributor

rhelmer commented Mar 30, 2021

I'm not sure what the gold standard is nowadays, but we should ratchet it up a bit, like always requiring braces around if/then/else statements and other potential safety issues.

I'm less concerned about style in general but it'd be nice to pick something comprehensive instead of a ruleset we need to maintain, since it's not very productive to argue about style nits in reviews :)

@jonathanmayer
Copy link
Contributor

@hamilton
Copy link
Contributor

hamilton commented Apr 5, 2021

I personally would opt for the Airbnb rules which I've used in the past. Many sensible defaults, and we can turn off the ones that are not joyful for us.

@jonathanmayer
Copy link
Contributor

Fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants