-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageText (article detection and content capture) not working on Chrome #280
Comments
OK, so Firefox has an https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/onUpdated#isarticle
I think we'll need to instead handle this in the callback, and use the Readability library (which is a standalone version of the code that powers Firefox's reader mode, and we already ship it in beyond-the-paywall. There's an npm package) |
Specifically the |
Small correction - we can't directly get the page contents from the listener (which is in the background script/worker), so instead I put the |
pageText
tries to pass filters tobrowser.tabs.onUpdated.addListener
which is Firefox-only, filtering needs to be done in the callback instead.The text was updated successfully, but these errors were encountered: