Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete event model migration for pageNavigation, linkExposure, socialMediaLinkSharing, and idle #17

Open
6 of 9 tasks
jonathanmayer opened this issue Mar 28, 2021 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jonathanmayer
Copy link
Contributor

jonathanmayer commented Mar 28, 2021

In the early versions WebScience, we implemented a measurement and storage model for these modules (i.e., each module ran an individual measurement and stored records of that measurement). We have partially transitioned to a WebExtensions-like event model for these modules, and there are some remaining items to complete.

Remaining items for pageNavigation:

  • Implement support for adding and removing multiple pageDataCallback listeners with differing PageDataOptions values.
  • Add logic to ensure that the associated content script only runs once per page.

Remaining items for linkExposure:

  • Implement support for adding and removing multiple linkExposureCallback listeners with differing LinkExposureOptions values.
  • Integrate untracked link exposures into linkExposureCallback and LinkExposureDetails, rather than using different (and undocumented) callback and detail types for untracked exposures. Note that the meaning of an untracked link will vary by listener, depending on its match patterns.
  • Add logic to ensure that the associated content script only runs once per page.

Remaining items for socialMediaLinkSharing:

  • Implement support for adding and removing multiple socialMediaShareCallback listeners with differing SocialMediaShareOptions values.
  • Correct the documentation for SocialMediaShareOptions.
  • Add documentation for SocialMediaShareDetails.

Remaining items for idle:

  • Implement support for removing onStateChanged listeners.
@jonathanmayer jonathanmayer added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 28, 2021
@jonathanmayer
Copy link
Contributor Author

A stale list of items for socialMediaLinkSharing: citp/news-disinformation-study#64

jonathanmayer added a commit that referenced this issue Apr 9, 2021
jonathanmayer added a commit that referenced this issue Apr 10, 2021
This update completes the migration to WebExtensions event syntax and fixes the minimum document height check on pages with unusual layouts (e.g., YouTube).
@jonathanmayer jonathanmayer changed the title Complete event model migration for pageNavigation, linkExposure, and socialMediaLinkSharing Complete event model migration for pageNavigation, linkExposure, socialMediaLinkSharing, and idle Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants