Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

rally.js must have the user's rally id in order to send glean.js pings #650

Open
1 of 3 tasks
hamilton opened this issue Jun 10, 2021 · 1 comment
Open
1 of 3 tasks
Assignees

Comments

@hamilton
Copy link
Contributor

hamilton commented Jun 10, 2021

This was caught by @Dexterp37. We will need the user's rally id in order to send the glean ping. One way we can make sure we have it is to store the rally id is for ._checkForRallyCore to return the rally id, which would be stored in the instance (something like instance.rallyID. This would enable us to pass it into the glean submission.

This requires us to:

  • publish a new version of rally.js
  • update the core add-on to pass the id
  • update RS01 (our testbed for glean.js) to use the new version of rally.js
@Dexterp37
Copy link
Contributor

Note: because this is defined as a 'user' lifetime metric, it only needs to be set once (it can be set multiple times too, but it's not required)

@rhelmer rhelmer self-assigned this Jun 10, 2021
rhelmer added a commit to rhelmer/rally-core-addon that referenced this issue Jun 10, 2021
rhelmer added a commit to rhelmer/rally-core-addon that referenced this issue Jun 10, 2021
rhelmer added a commit to rhelmer/rally-core-addon that referenced this issue Jun 10, 2021
rhelmer added a commit that referenced this issue Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants