Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

CI or some automated process is sending Glean enrollment pings to our tables #639

Open
hamilton opened this issue Jun 2, 2021 · 4 comments

Comments

@hamilton
Copy link
Contributor

hamilton commented Jun 2, 2021

We have a large number or rows in rally_core.enrollments_v1 that we shouldn't have – hundreds, in fact. Given that they seem to be coming from Ashburn, VA, it's pretty clear that our CI is successfully submitting pings – maybe in integration tests. We should probably fix that.

@rhelmer
Copy link
Contributor

rhelmer commented Jun 2, 2021

We have a large number or rows in rally_core.enrollments_v1 that we shouldn't have – hundreds, in fact. Given that they seem to be coming from Ashburn, VA, it's pretty clear that our CI is successfully submitting pings – maybe in integration tests. We should probably fix that.

Is this Glean, or legacy Telemetry? I'd guess that it's an indication that either

  1. rally-core is not correctly disabling data submission in dev mode, or
  2. integration tests are incorrectly doing production and not dev builds

@Dexterp37
Copy link
Contributor

Is this Glean, or legacy Telemetry? I'd guess that it's an indication that either

That's the rally_core Glean namespace, but if that happens with Glean is 100% happening in the legacy telemetry, too.

1. rally-core is not correctly disabling data submission in dev mode, or

Given the scale, I think this is unlikely.

2. integration tests are incorrectly doing production and not dev builds

I think integration tests are doing production build, but I don't think that's incorrect (generally speaking).
To solve this:

  • for legacy telemetry, set the "toolkit.telemetry.server" pref to localhost before Firefox starts, with Selenium;
  • for Glean, you can either mark the pings when initializing using the automation sourceTags (i.e. {... other configuraiton..., debug: { sourceTags: ["automation"] }) or set upload disabled when initializing on CI.

@hamilton
Copy link
Contributor Author

hamilton commented Jun 3, 2021

@Dexterp37 This is not happening on legacy telemetry (pioneer_core) – just in rally_core. It could be that the pref is already flipped in Selenium. @rhelmer this would be worth checking.

At any rate, this is perfect – thanks for the recommendation & documentation.

@Dexterp37
Copy link
Contributor

@Dexterp37 This is not happening on legacy telemetry (pioneer_core) – just in rally_core. It could be that the pref is already flipped in Selenium. @rhelmer this would be worth checking.

Interesting, that is unexpected :-) Let me know what you find out, I'm curious!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants