Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests that do not depend on a specific repo state #56

Open
st3fan opened this issue Mar 3, 2021 · 0 comments
Open

Create tests that do not depend on a specific repo state #56

st3fan opened this issue Mar 3, 2021 · 0 comments

Comments

@st3fan
Copy link
Contributor

st3fan commented Mar 3, 2021

Some tests look at st3fan/fenix or st3fan/android-components. Since those forks are used for development, they are not guaranteed to be stable.

So some tests that pull data from them fail:

    def test_get_recent_fenix_versions(gh):
>       assert get_recent_fenix_versions(gh.get_repo(f"st3fan/fenix")) == [83, 88]
E       assert [86, 87] == [83, 88]
E         At index 0 diff: 86 != 83
E         Use -v to get the full diff

We can update the tests, but it is better to figure out a better way with more stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant