Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I would like an example of how to place the toolbar at the top of the screen so that I can easily add a toolbar position switch to my settings (like Fenix) #2091

Open
paidforby opened this issue Nov 9, 2022 · 0 comments
Labels
🌟 feature New functionality and improvements

Comments

@paidforby
Copy link

The reference browser defaults to placing the BrowserToolbar at the bottom of the screen. However, as a developer, I would like to allow user's to switch the position of the toolbar. I attempted doing this in what seems like the "right" way in a fork, see this commit, paidforby@dc9656e. But this results in two problems:

  1. The top part of the engineView content is covered by the toolbar
  2. When scrolling down the page, the toolbar hides as expected, but a margin pops up at the bottom of the screen, cutting off the bottom of the engineView content.

I will be satisfied if solutions are provided for these issues. Ideally, a simple switch preference should be added to the reference browser settings that changes the position of the toolbar for demonstrative purposes.

@paidforby paidforby added the 🌟 feature New functionality and improvements label Nov 9, 2022
paidforby added a commit to paidforby/reference-browser that referenced this issue Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 feature New functionality and improvements
Projects
None yet
Development

No branches or pull requests

1 participant