Skip to content
This repository has been archived by the owner on Apr 28, 2018. It is now read-only.

Place list includes places outside of filters after filtering #541

Open
mcomella opened this issue Feb 23, 2017 · 1 comment
Open

Place list includes places outside of filters after filtering #541

mcomella opened this issue Feb 23, 2017 · 1 comment
Labels

Comments

@mcomella
Copy link
Contributor

mcomella commented Feb 23, 2017

Examples:

  • If you have one place, there will be multiple cards remaining. Also, re-enabling filters will not allow you to swipe through the full card set. You can reproduce this at the SF office.
  • Disabling all filters should show 0 places (but it's shows some)
  • The currently selected places are not filtered out (even with ^)

I think the problem is that we're not managing our linked list of displayed places correctly in PlaceDetailViewController. Quick fix: refresh the linked list entirely.

@mcomella
Copy link
Contributor Author

mcomella commented Mar 9, 2017

  • If you have one place, there will be multiple cards remaining. Also, re-enabling filters will not allow you to swipe through the full card set. You can reproduce this at the SF office.

I think this is still broken, but unlikely to happen in our chicago user test.

  • Disabling all filters should show 0 places (but it's shows some)

We no longer allow you to disable all the filters.

  • The currently selected places are not filtered out (even with ^)

We haven't seen this in a while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant