Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage CFR shows incorrectly on non-homepage site #20199

Open
data-sync-user opened this issue May 10, 2024 · 0 comments
Open

Homepage CFR shows incorrectly on non-homepage site #20199

data-sync-user opened this issue May 10, 2024 · 0 comments

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented May 10, 2024

Steps:

There are probably several different ways to trigger this, steps I used are below and seem to be 100% reproducible:

  1. Fresh install of app
  2. Launch app, type in google.com on the first tab and hit return to load
  3. Add a new tab, and type bing.com, hit return to load

Result: the homepage CFR shows and after the webpage loads it remains in place, showing incorrectly on the non-homepage site

Expected: at minimum we should hide the CFR if the user leaves the homepage. The exact UX in this flow might need additional discussion (e.g. do we re-show the CFR if we can detect it was not displayed long enough for the user to read it)

!Simulator Screenshot - iPad (10th generation) - 2024-05-10 at 11.07.12.png|width=2360,height=1640,alt="Simulator Screenshot - iPad (10th generation) - 2024-05-10 at 11.07.12.png"!

┆Issue is synchronized with this Jira Bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant