Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "search.default_engine" early in startup to avoid null value #20167

Open
data-sync-user opened this issue May 7, 2024 · 3 comments
Open
Assignees

Comments

@data-sync-user
Copy link
Collaborator

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator Author

➤ Alina Moldovan commented:

Please see below the testing results using FF v1256 (41677) and iPhone 15+ (17.4.1)

  1. No search.defaultEngine mertric is received. we always receive only search.default_engine metric
  2. the following successive events were generated when we run the following steps:
    1. Set the telemetry ON on the device
    2. Received some events like:
    1. "string": {
      "search.default_engine": "google-b-m"
      },
3. Changed the default search engine 
4. Check the glean events:
  1. First event:

{
"category": "preferences",
"extra": {
"changed_to": "ddg",
"glean_timestamp": "1715247162942",
"preference": "defaultSearchEngine"
},
"name": "changed",
"timestamp": 59859
}
2. Second event:
3. "string": {
"search.default_engine": "ddg"
}

Roux Buciu this seems to be the same behavior as before (used v125 (41705) build for comparation).

Could you please let us know if the testing scenario is correct? if not could you please add some details about what we should test? Also, scould you please change the ticket status to “QA needed“?

CC Norberto Andres Furlan Diana Andreea Barladeanu

@data-sync-user
Copy link
Collaborator Author

➤ Roux Buciu commented:

Heya. yes, it’s search.default_engine in the metrics. It’s search.defaultEngine in the code, which is why I wrote that originally. lol

This testing scenario seems fine. The problem is that we don’t really know where the issue occurs/don’t have steps to reproduce, so, the additional metrics that have been added will probably only trigger on a mass scale wherever the issue is happening.

@data-sync-user data-sync-user changed the title Add Search.defaultEngine early in startup to avoid null value Add "search.default_engine" early in startup to avoid null value May 9, 2024
@data-sync-user
Copy link
Collaborator Author

➤ Alina Moldovan commented:

Marking this issue as verified based on the previous comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants