Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include validator version in anonymized exports #21

Open
ghost opened this issue Jan 13, 2017 · 3 comments
Open

Include validator version in anonymized exports #21

ghost opened this issue Jan 13, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 13, 2017

I just saw a screenshot of an export where the mobile root shows up under "records appear on the server but should not have been uploaded". IIUC, Thom fixed that in https://bugzilla.mozilla.org/show_bug.cgi?id=1309774, so now I'm wondering if that's from an older version of the validator, or if something else is going on.

Including the validator version in the export, like we do for the ping, would help figure this out.

Validator screenshot

@mhammond
Copy link
Collaborator

👍

@mhammond
Copy link
Collaborator

mhammond commented Feb 6, 2017

Thinking some more about this, I'm not sure it's valuable or even possible - we don't export the validation data, we just export the local and server info, and the validator in the version of Firefox which reads the export is the version used to perform the validation.

It might be useful to include the validator info in the UI so screenshots like the above make it more obvious, but we probably want to discourage people from using screenshots anyway.

@kitcambridge, what do you think?

@thomcc
Copy link
Contributor

thomcc commented Feb 12, 2017

I think there's a good argument that we should export validation data, since the validator isn't 100% accurate when run on non-local data, e.g. it does make some places calls inside it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants