Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about:debugging page indicates that the About Sync extension has an invalid version number #110

Open
dholbert opened this issue Jan 23, 2023 · 2 comments

Comments

@dholbert
Copy link

STR:

  1. Install the About Sync add-on from https://addons.mozilla.org/en-US/firefox/addon/about-sync/
  2. Visit about:debugging and scroll down to the entry for About Sync (under "Extensions")

ACTUAL RESULTS:
There's a warning box -- if you expand it, it shows the following:

Warning details

Reading manifest: Warning processing version: version must be a version string consisting of at most 4 integers of at most 9 digits without leading zeros, and separated with dots

Here's a screenshot:
image

EXPECTED RESULTS:
No such warning (i.e. we probably need a conforming version numbering scheme).

If you look at the Version field on https://addons.mozilla.org/en-US/firefox/addon/about-sync/ , you can see that indeed our version number does not conform to this "at most 4 integers of at most 9 digits without leading zeros, and separated with dots" scheme -- we have right now:

Version
    0.21.0buildid20220714.054802
@dholbert
Copy link
Author

I'm using Firefox Nightly, version 111.0a1 (2023-01-21) (64-bit)

@willdurand
Copy link
Member

This isn't unexpected but it isn't a problem as long as this extension continues to be a MV2 extension. This new version string format is enforced for MV3+ extensions. This will need to be fixed in the pipeline itself, see mozilla-extensions/xpi-manifest#185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants