Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cameras previews don't fit to full browser window #2583

Open
lowlyocean opened this issue Aug 29, 2022 · 3 comments · May be fixed by #2590
Open

Cameras previews don't fit to full browser window #2583

lowlyocean opened this issue Aug 29, 2022 · 3 comments · May be fixed by #2590
Assignees
@lowlyocean
Labels
bug CSS JavaScript
Milestone
v0.43.1

Comments

@lowlyocean
Copy link
Contributor

With 4 cameras, I expected Layout Columns = 2, Layout Rows = 2 and Fit Frames Vertically enabled would make all previews scale to fit into equally sized quadrants as I resize the window. Is there anyway to achieve that behavior? I find myself having to scroll even when F11 my browser into full screen mode, because the bottom of the 2nd row doesn't fit the window.
@zagrim
Copy link
Collaborator

zagrim commented Aug 30, 2022

Only Layout Columns does actually squeeze the frames into the available space, Layout Rows doesn't do that and that can be seen as a bug. What Fit Frames Vertically switch does is to enable Layout Rows and basically the vertical size control, so in principle you are correct with your assumption that it should work.
What is your screen resolution and the camera frame sizes?

@lowlyocean
Copy link
Contributor Author

My screen resolution is 1920x1080. The first 3 cameras are 352x240, and the 4th camera is 320x240

@lowlyocean lowlyocean linked a pull request Sep 7, 2022 that will close this issue
Open
@lowlyocean
Copy link
Contributor Author

lowlyocean commented Sep 7, 2022 •
edited

Mind reviewing PR? Tested with 4 cameras, various combinations of rows/columns renders as expected (with and without settings panel active, both >1200 and <1200 window width). There's no inherent reason for it to not work with different # of cameras.

@MichaIng MichaIng linked a pull request Sep 11, 2022 that will close this issue
Fit vertically 2x2 as expected #2590
Open
@MichaIng MichaIng added bug and removed enhancement labels Sep 11, 2022
@MichaIng MichaIng added this to the v0.43.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowlyocean lowlyocean

Labels
bug CSS JavaScript
Milestone
v0.43.1
Development

Successfully merging a pull request may close this issue.

Fit vertically 2x2 as expected lowlyocean/motioneye
3 participants
@lowlyocean @zagrim @MichaIng