Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code test is flaky #25

Closed
samestep opened this issue Mar 23, 2021 · 1 comment · Fixed by #29
Closed

VS Code test is flaky #25

samestep opened this issue Mar 23, 2021 · 1 comment · Fixed by #29

Comments

@samestep
Copy link
Collaborator

These are the last 25 lines of output from the "Run tests" step in the vscode job of this failed run for 3d5398c (part of #23):

  Quench

    1) correctly reports syntax error(s) for "Hello, world!"

  0 passing (2s)

  1 failing

  1) Quench
       correctly reports syntax error(s) for "Hello, world!":
     Error: TextEditor#edit not possible on closed editors
  	at Object.edit (.vscode-test/vscode-linux-x64-1.54.3/VSCode-linux-x64/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87:49471)
  	at Context.<anonymous> (out/test/suite/extension.test.js:39:22)


No authentication provider 'github' is currently registered.

Settings Sync: Accounts are not initialized

Exit code:   1
Done

Failed
Failed to run tests.
Error: Process completed with exit code 1.

The failure corresponds to line 44 of editors/code/src/test/suite/extension.test.ts from the same commit. My first thought was that this is a race condition caused by sleeping for a second on line 40, but commenting out line 40 doesn't do anything when I run the tests locally (they succeed), so I'm not sure exactly what this is.

@samestep
Copy link
Collaborator Author

The same failure happened again: https://github.com/quench-lang/quench/runs/2172247536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant