Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflows card #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add workflows card #32

wants to merge 1 commit into from

Conversation

umesh-timalsina
Copy link
Member

image

jennyfothergill
jennyfothergill approved these changes May 6, 2021
View reviewed changes
Copy link

@jennyfothergill jennyfothergill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :) I have a couple minor suggestions (I realize these are outside of the scope of this PR, so address them at your discretion):

  • Let's change the title for Mosdef Tutorials to MoSDeF Tutorials to maintain consistency.
  • Do we still need cards for mbuild and foyer tutorials since they are contained in MoSDeF tutorials?
  • Since nanoopt and msibi haven't been touched in a while, maybe we should move their cards further down in the list and bump mosdef tutorials and workflows.

index.html
<div class="card small banner-background">
<div class="card-content white-text">
<div class="card-title">MoSDeF Workflows</div>
<p>Curated demo workflows using MoSDeF the framework</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>Curated demo workflows using MoSDeF the framework</p>
<p>Curated demo workflows using the MoSDeF framework</p>

minor rewording.
It might also be nice if we mention that these branch out into various simulation engines.

@jennyfothergill
Copy link

jennyfothergill commented May 6, 2021 •
edited

fixes #29 (sorry I don't see a way to link this issue--might need some admin help) ty justin :)

@justinGilmer justinGilmer linked an issue May 6, 2021 that may be closed by this pull request
Make mosdef-workflows easier to find #29
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyfothergill jennyfothergill jennyfothergill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make mosdef-workflows easier to find
2 participants
@umesh-timalsina @jennyfothergill