Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description of how surface was generated #885

Open
jennyfothergill opened this issue Apr 27, 2021 · 1 comment
Open

Add description of how surface was generated #885

jennyfothergill opened this issue Apr 27, 2021 · 1 comment

Comments

@jennyfothergill
Copy link
Contributor

TODO comments from mbuild/lib/surfaces/amorphous_silica_surface.py

11-        if surface_roughness == 1.0:
12:            # TODO: description of how this surface was generated/citation
13-            mb.load('amorphous_silica_sr1.0.pdb', compound=self,
14-                    relative_to_module=self.__module__)

related to #872
jennyfothergill added a commit to jennyfothergill/mbuild that referenced this issue Apr 27, 2021
@jennyfothergill
see mosdef-hub#885
5e9a4d7
justinGilmer pushed a commit that referenced this issue Apr 27, 2021
@jennyfothergill
Remove TODO comments (#876)
1ca3ff8 
* remove todo, see issue #875

* see #877

* see #878

* see #879

* see #880

* see #881

* see #882

* see #883

* see #884

* see #885

* see #886
umesh-timalsina referenced this issue in GOMC-WSU/MoSDeF-GOMC Mar 22, 2022
@jennyfothergill
Remove TODO comments (#876)
1096d19 
* remove todo, see issue #875

* see #877

* see #878

* see #879

* see #880

* see #881

* see #882

* see #883

* see #884

* see #885

* see #886
@CalCraven
Copy link
Contributor

We would need someone with that information here. @chrisiacovella do you have that info anywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennyfothergill @CalCraven