Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lists with labels in coarse_graining.py #879

Open
jennyfothergill opened this issue Apr 27, 2021 · 1 comment
Open

Support lists with labels in coarse_graining.py #879

jennyfothergill opened this issue Apr 27, 2021 · 1 comment

Comments

@jennyfothergill
Copy link
Contributor

TODO comments from mbuild/coarse_graining.py

179-def _create_proxy_labels(real_thing, memo):
180-    if not is_leaf(real_thing):
181-        for label, part in real_thing.labels.items():
182-            if isinstance(part, list):
183:                # TODO support lists with labels
184-                continue

related to #872
jennyfothergill added a commit to jennyfothergill/mbuild that referenced this issue Apr 27, 2021
@jennyfothergill
see mosdef-hub#879
c4fb334
justinGilmer pushed a commit that referenced this issue Apr 27, 2021
@jennyfothergill
Remove TODO comments (#876)
1ca3ff8 
* remove todo, see issue #875

* see #877

* see #878

* see #879

* see #880

* see #881

* see #882

* see #883

* see #884

* see #885

* see #886
umesh-timalsina referenced this issue in GOMC-WSU/MoSDeF-GOMC Mar 22, 2022
@jennyfothergill
Remove TODO comments (#876)
1096d19 
* remove todo, see issue #875

* see #877

* see #878

* see #879

* see #880

* see #881

* see #882

* see #883

* see #884

* see #885

* see #886
@CalCraven
Copy link
Contributor

Does anybody have a specific use case for this in mind? We may have a workaround up to this point since this was never addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennyfothergill @CalCraven