Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change utils/conversion.py function name "RB_to_CHARMM" --> "RB_to_periodic" #1050

Open
bc118 opened this issue Aug 16, 2022 · 0 comments
Open

change utils/conversion.py function name "RB_to_CHARMM" --> "RB_to_periodic" #1050

bc118 opened this issue Aug 16, 2022 · 0 comments

Comments

@bc118
Copy link
Contributor

bc118 commented Aug 16, 2022

The mbuild/utils/conversion.py function name "RB_to_CHARMM" should be changed to "RB_to_periodic" because the CHARMM-style dihedral C0 is technically a harmonic dihedral, which is different from the periodic dihedral from C1-C5.

This change will make it clearer for the users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bc118