Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist for Adding OPLS Parameters #314

Open
rmatsum836 opened this issue Feb 13, 2020 · 0 comments
Open

Checklist for Adding OPLS Parameters #314

rmatsum836 opened this issue Feb 13, 2020 · 0 comments

Comments

@rmatsum836
Copy link
Contributor

A summary of the question or discussion topic.
I've realized over the last couple weeks working with @Argon1999 to improve our OPLS coverage that the instructions for doing so aren't immediately clear nor well-documented. As we continue to improve our OPLS.xml I wanted to make sure the steps for doing so are clearly outlined:

  1. Identify OPLS types that need SMARTS definitions from GROMACS files (https://github.com/gromacs/gromacs/tree/master/share/top/oplsaa.ff)
  2. Define SMARTS strings and description for each type. Add bond, angle, dihedral definitions for the atom type if not already done so.
  3. Generate and add GROMACS gro and top files into a directory that corresponds to a molecule in opls_validation (Make sure these structure files are for a single molecule) These files will be used to test that the molecule can be correctly atom-typed.
  4. in foyer/tests run python test_opls.py. This will run the find_correctly_implemented function that will attempt to atom-type the molecules contained within opls_validation. If the new molecules are correctly atom-typed by the new SMARTS definitions, then the molecule names will be appended to implemented_opls.txt.
  5. Run pytest test_opls.py. If all tests pass, then the SMARTS definitions have been correctly implemented.
@daico007 daico007 pinned this issue Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant