Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we record the path from which an XML is loaded? #301

Open
mattwthompson opened this issue Dec 7, 2019 · 3 comments
Open

Should we record the path from which an XML is loaded? #301

mattwthompson opened this issue Dec 7, 2019 · 3 comments
Labels

Comments

@mattwthompson
Copy link
Member

See @uppittu11's comment: #298 (review)

Another thing we could add is an attribute to the Forcefield class which gives the path from which the forcefield was loaded. This wouldn't be saved in the forcefield xml, but is only an attribute. This might be a dumb idea, since we might have issues comparing two of the same forcefield loaded from different paths.

I think this could be useful but don't feel strongly about it one way or the other. What does everybody else think?

@ahy3nz
Copy link
Contributor

ahy3nz commented Jan 6, 2020

In the grand scheme of conda-installable FF repos, file paths for those XMLs could be unnecessary if they're hidden away in 5 conda folders somewhere? But in the current status of git cloning and pip installing, it could be helpful for debugging purposes for a user to know exactly where the XML is? Otherwise, foyer could have a large list of entry points and force field names, but a user might not remember which force field entry point corresponds to which file path?

@ahy3nz
Copy link
Contributor

ahy3nz commented Jan 6, 2020

related: openforcefield/openff-toolkit#477

@InnocentBug
Copy link

Just an idea, while browsing these issues.
Maybe instead of logging the file path to log a hash of the forcefield files used.
This enables at least to verify that one specific forcefield has been used.
It does not allow full reconstruction, but verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants