Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility support for ItemsList #53

Open
rockerBOO opened this issue Oct 12, 2019 · 0 comments
Open

Add accessibility support for ItemsList #53

rockerBOO opened this issue Oct 12, 2019 · 0 comments

Comments

@rockerBOO
Copy link

rockerBOO commented Oct 12, 2019

Add id attributes (or other attributes) to the <ul in <ItemsList>.

https://i.imgur.com/n2IbiWo.png

Firefox accessibility issue checker

The new beta Firefox accessibility issue checker is suggesting that the listbox element be labeled. There is no way to currently label that element because <label>Results<ul ...>...</ul></label> does not seem to work.

<ul {...props.itemsListProps}>
<ul id={props.itemsListId}>
<ul aria-label={props.itemsListLabel}>

<Container>
  <label htmlFor={props.itemsListId}>Results</label>
   {children} // <ul ...>...</ul>
</Container>

This is in concern with react-autosuggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant