Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove componentWillReceiveProps, React 16.9.0 deprecates it. #50

Open
jimnanney opened this issue Aug 29, 2019 · 3 comments
Open

Remove componentWillReceiveProps, React 16.9.0 deprecates it. #50

jimnanney opened this issue Aug 29, 2019 · 3 comments

Comments

@jimnanney
Copy link

React 16.9.0 deprecates the componentWillReceiveProps lifecycle method and throws warnings for it use.

Looking through Autowhatever.js, it appears it is only used for computing theme, sectionItems and sectionIterator. These could be moved to the render function, and if it is expensive, could be memoized.
@jimnanney jimnanney mentioned this issue Aug 29, 2019
Open
@dezemand
Copy link

Just renaming to UNSAFE_componentWillReceiveProps will break older React versions.

@jimnanney
Copy link
Author

My PR did not rename it, just moved the functionality into the render function.

@dezemand
Copy link

That’s right, however commit 652a909 did rename the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimnanney @dezemand