Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on react-themeable #25

Open
bbenezech opened this issue Jan 13, 2017 · 4 comments
Open

Remove dependency on react-themeable #25

bbenezech opened this issue Jan 13, 2017 · 4 comments

Comments

@bbenezech
Copy link

It's a 10ish lines lib that relies on an outdated version of object-assign (3.0.0 when everyone has moved on to 4.1.0). It looks unmaintained :(

It smells funny on the otherwise clean react-autosuggest dependency tree.

I'd say either inline its code or remove the functionality, it looks like the idea hasn't caught on :(

@moroshko
Copy link
Owner

@markdalgleish Any plans to continue maintaining react-themeable?

it looks like the idea hasn't caught on

@bbenezech Do you mean the whole idea of allowing people to style react-autosuggest using their preferred styling solution?

or remove the functionality

Does it mean we force everyone to use inline styles (or something else)?

I'd love to hear more thoughts on this topic.

@markdalgleish
Copy link

markdalgleish commented Jan 14, 2017 via email

@moroshko
Copy link
Owner

@yoadsn
Copy link

yoadsn commented Jan 12, 2019

@moroshko 2.5y without changes to react-themeable I believe it's safe to declare this as unmaintained. We use the theme functionality and it's great but resent the old object-assign dependency which duplicates this package. Would love to see this lib move away from this dependency and only if to not seem as unmaintained as it might seem now.
Inlining this lib code would at least give an opening for nested keys support PR should anyone from the community want that enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants