Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Publish 0.7.0 #52

Open
3 tasks
gagbo opened this issue Sep 2, 2022 · 4 comments
Open
3 tasks

[Maintenance] Publish 0.7.0 #52

gagbo opened this issue Sep 2, 2022 · 4 comments

Comments

@gagbo
Copy link
Collaborator

gagbo commented Sep 2, 2022

Hello,

This issue serves as marker/reminder that even in the 0.7.0 version has been properly merged and tagged in the main branch, it hasn't been pushed to crates.io yet because I don't "own" the crate there; and the new version of the book has been merged but not deployed either as far as I understand.

To publish:

  • ktra 0.6.0 on crates.io
  • ktra 0.7.0 on crates.io
  • moriturus/ktra-book@6th_edition on book.ktra.dev
@fMeow
Copy link
Collaborator

fMeow commented Sep 2, 2022

AFAIK 0.6.0 is not released to crates.io yet. So I don't think it necessary to bump a minor version.

@gagbo
Copy link
Collaborator Author

gagbo commented Sep 2, 2022

Actually, as long as the major version is a leading 0, the "minor" version is the major compatibility version as far as cargo is concerned. I pushed 0.7.0 before realizing this, but fortunately, as ktra is a binary-only crate (at least for the time being), those semver details don't matter too much.

0.6.0 tag was already existing and pushed in the repo here, so there was no reason to overwrite this tag; I guess that means we'll need to publish the 2 versions to crates.io now, instead of just one. Thanks for noticing that and adding the task to the reminder!

@fMeow
Copy link
Collaborator

fMeow commented Sep 3, 2022

I would recommend a automatic flow to publish commit with version tag to crates.io, which can be realized by github action.

I would draft a PR and wait for the crates.io owner to fill the missing token in repo setting.

@fMeow
Copy link
Collaborator

fMeow commented Sep 3, 2022

I have submit PR #53, which add publish section in github action. The only missing piece is a correct CARGO_TOKEN provided and configured by @moriturus in action secrets in repo settings.

Let's wait for response from @moriturus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants