Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for contact fields that may be null #737

Open
thisjeremiah opened this issue May 11, 2024 · 1 comment
Open

Update types for contact fields that may be null #737

thisjeremiah opened this issue May 11, 2024 · 1 comment

Comments

@thisjeremiah
Copy link

thisjeremiah commented May 11, 2024

It seems that givenName and familyName could be null for fetched contacts on Android devices. This possibility is not reflected in the current TS types.

This scenario can be reproduced by creating a contact with no name and only an "important date" (eg birthday) on Android.

If this doesn’t seem like a bug in the implementation, I can make a PR to update the typings for these fields.

@morenoh149
Copy link
Owner

@thisjeremiah please submit a pr updating the typings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants