Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSLScanner fails while creating symlinks or after creating shortcuts #206

Open
Sythog opened this issue Feb 13, 2024 · 3 comments
Open

NSLScanner fails while creating symlinks or after creating shortcuts #206

Sythog opened this issue Feb 13, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Sythog
Copy link

Sythog commented Feb 13, 2024

if os.path.exists(current_path):

I already have symlinks for the launchers I have installed named exactly as folder name in the folder_names dictionary. The script enters the if condition on L466 and attempts to rename the symlink to the appid on L475. Of course, it fails and no shortcuts are created :(

I changed L466 to

 if os.path.exists(current_path) and not os.path.islink(current_path): 

but the script hangs after printing "Created shortcuts"

@Sythog Sythog changed the title NSLScanner fails while creating symlinks NSLScanner fails while creating symlinks or after creating shortcuts Feb 13, 2024
@moraroy moraroy added the bug Something isn't working label Feb 14, 2024
@Sythog
Copy link
Author

Sythog commented Feb 16, 2024

@moraroy hey, do you have any thoughts and/or plans on that?
please don't hesitate to let me know if you need any help. I'm not a python guru, but I know a thing or two.
I just need a general direction on where to start with this if you'd like me to make a contribution

@moraroy
Copy link
Owner

moraroy commented Feb 16, 2024

@Sythog yes I do actually, currently concentrating in making the decky plugin version a but better sorry I haven't got back to you. I do have a plan actually I would like to get rid of the symlinks in the compatdata folder all together. You have discord? Message me @moraroy

@Sythog
Copy link
Author

Sythog commented Feb 17, 2024

Is being addressed in #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants