Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer embed album art to folder album art #39

Open
NyaomiDEV opened this issue Feb 1, 2020 · 3 comments
Open

Prefer embed album art to folder album art #39

NyaomiDEV opened this issue Feb 1, 2020 · 3 comments

Comments

@NyaomiDEV
Copy link

AKA: If the track does have an album art, grab that instead of the folder album art.

This is because there may be random images in the tracks' folder, such as booklet scans.
Also, this would fix a current issue where some singles don't have any art displayed even if they have their own embedded in their tags. That's because some media players create an "AlbumArt.jpg" / "Folder.jpg" on folders full of singles; then Mopidy-Local scans the folder and doesn't know what to do precisely (and I personally noticed this behaviour, I don't even know if it's somewhat intended at this point).
This issue could be worked around by creating a subfolder per file, but that process is tedious and problematic for huge music collections.

@orontee
Copy link
Contributor

orontee commented Dec 19, 2020

I faced that problem with a music library managed with MusicBrainz Picard application. But playing with the application parameters, the image for the front cover can be named cover.jpg even when there's other images for the booklet, etc. Then customizing mopidy-local album_art_files one can have the front cover image to be used.

@fkuersch
Copy link

I have a bunch of unrelated MP3 files with embedded images. mopidy-local doesn't extract the image of the single track. But if I set the 'artist' and 'album' metadata, mopidy-local does find and extract the image.

Unfortunately, this method also spams the "My Albums" section in mopidy-iris by creating an album for each individual file.

@jotak
Copy link

jotak commented Aug 7, 2022

Maybe the approach for providing art should be changed more deeply: instead of having a list of images per album (which is per design in the database), it should more stick to the actual model with 1 or 0 image per track, and 1 or 0 image per album.

That would of course break the Mopidy-Local API, so it is then up to the frontends to display the correct image depending on the situation. But I think it would solve many problems (including what @fkuersch mentions about albums view bloated with different images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants