Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Album Artists" to root directories #18

Open
tkem opened this issue Nov 26, 2014 · 9 comments
Open

Add "Album Artists" to root directories #18

tkem opened this issue Nov 26, 2014 · 9 comments
Labels
C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal

Comments

@tkem
Copy link
Member

tkem commented Nov 26, 2014

It's already supported in v0.8.0, just needs to be included in the default configuration:

directories =
    Albums              local:directory?type=album
    Album Artists       local:directory?type=artist&role=albumartist
    Artists             local:directory?type=artist
[...]

Some people may prefer it to the way "Artists" are handled, and it might help with support issues, e.g. "artist" tags vs. "albumartist" tags. Note that MPDroid also has a "Use album artists" setting for its local browse configuration.

@tkem
Copy link
Member Author

tkem commented Dec 1, 2014

First, browsing "Album Artists" should give proper "local:album:" URIs...

@tkem
Copy link
Member Author

tkem commented Mar 15, 2015

Also re-think get_distinct vs. browse URIs...

@jaedb
Copy link

jaedb commented Jun 9, 2018

@tkem I'm particularly interested in this issue as it'll make the Iris frontend a bit more versatile. Has any progress been made on this?

@tkem
Copy link
Member Author

tkem commented Jun 9, 2018

@jaedb: As mentioned initially, this should already be possible (with some quirks, maybe) by manually adding it to the configuration.
Otherwise, no progress on this, since I'm not actively using mopidy-local-sqlite myself any more and nobody else jumped on it. Maybe we should add a "maintainer wanted" sign up there, but that's why this got transferred to the "mopidy" org in the first place, IIRC.

@jaedb
Copy link

jaedb commented Nov 11, 2019

@tkem a belated follow-up question: if you're not using Mopidy-Local-SQLite, what backend extension are you using?

@tkem
Copy link
Member Author

tkem commented Nov 12, 2019

@jaedb: I've been using mopidy-dleyna with the minidlna media server for the last couple of years.

@tkem tkem transferred this issue from mopidy/mopidy-local-sqlite Dec 9, 2019
@jodal jodal added the C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal label Dec 21, 2019
@amitkeret
Copy link

@tkem looking at the source code, it seems that this filter will only display tracks where albumartist is explicitly defined

"albumartist": """EXISTS (

therefor, since most single-artist album tracks are unlikely to have this definition, the usability of this filter is questionable.

would it be possible to rewrite this query so it doesn't exclude tracks, but rather reverts to artist field, if no albumartist is defined?
I think this would be more useful; it would mean that compilation albums would be listed based on their albumartist field, and would ALSO list single-artist album tracks as well.

thank you

@tkem
Copy link
Member Author

tkem commented Sep 15, 2020

@amitkeret: It's been some time since I've been using this, but IIRC most tracks (at least the ones I've encountered) will also provide an albumartist tag, which usually matches artist unless it's part of a compilation album.

@amitkeret
Copy link

amitkeret commented Sep 16, 2020

I can confirm that my artist list is significantly filtered if I use role=albumartist, meaning that the tracks do not provide/fallback to providing albumartist tag if this is not explicitly defined
@jodal any ideas?

Mopidy 3.0.2
Mopidy-Local 3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Projects
None yet
Development

No branches or pull requests

4 participants