Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use beets python API instead of web API? #29

Open
nmeum opened this issue May 25, 2020 · 2 comments
Open

Use beets python API instead of web API? #29

nmeum opened this issue May 25, 2020 · 2 comments

Comments

@nmeum
Copy link

nmeum commented May 25, 2020

Recently, beets developers started documenting their python API. IMHO the web plugin is a bit clumsy (there are plans to improve it though) but maybe it makes sense to use the python API instead? This should also allow simplifications of the code base, e.g. the code in client.py could basically be removed then. Furthermore, it doesn't require users to start a separate services (beets web) to interface with beets from mopidy.

@mgoltzsche
Copy link
Contributor

mgoltzsche commented Dec 5, 2023

Fwiw Integration with beets via Python API directly would tighten the coupling between mopidy and beets (which would potentially introduce maintenance problems down the road, e.g. conflicting python dependency versions) and prevent (re-)deploying beets independently from mopidy as well as accessing a remote beets library from within mopidy (e.g. see #3).
(The Microservice architecture is a common pattern for such a system and is already implemented by letting mopidy use beets via its web API.)

@sumpfralle
Copy link
Contributor

IMHO the web plugin is a bit clumsy [..]

Indeed! I share this feeling, @nmeum.

But personally, I would still prefer to stick to the (http-based) API, since I appreciate the possibility to decouple mopidy and beets on different hosts (as emphasized by @mgoltzsche).

(maybe I will finally manage to push myself into implementing #3 in the next weeks ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants