Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Moonlight process stays running on stream termination #939

Closed
Chris3773 opened this issue Jan 25, 2023 · 2 comments · May be fixed by #977
Closed

[Bug] Moonlight process stays running on stream termination #939

Chris3773 opened this issue Jan 25, 2023 · 2 comments · May be fixed by #977

Comments

@Chris3773
Copy link

Chris3773 commented Jan 25, 2023 •
edited

Describe the bug
When using Sunshine as the host and launching an app from the command line Moonlight.exe will stay running when the stream terminates. The window is closed but the Moonlight.exe process is still running. When a stream is terminated, the app exited from within the stream, Sunshine handles the termination differently then GeForce Experience. Maybe a problem on both sides as GeForce Experience does not have this problem. In any case the Moonlight.exe process should terminate when this happens.

Steps to reproduce

  1. Run the Sunshine host.
  2. Launch an app from the cmd: Moonlight.exe stream "{Computer}" "{App}"
  3. Close the app within the stream.
  4. Check that the 'Moonlight.exe' is still running on the system.

Other Moonlight clients
The Android app will show a terminated alert when the app is terminated within the stream.

Moonlight settings (please complete the following information)
This does happen with default settings.

Client PC details

  • OS: Windows 10 19045
  • Moonlight Version: 4.3.1
  • GPU: Intel Iris Xe Graphics

Server PC details

  • OS: Windows 10 19045
  • Sunshine version: v0.17.0
  • Nvidia GPU driver: 528.24
  • Antivirus and firewall software: Windows Defender and Windows Firewall

Moonlight Logs
moonlight.log
@bocki
Copy link

bocki commented Mar 26, 2023

I'm not completely sure this is unique to sunshine as this is happening to me as well, but using GFE and using the latest Linux CI AppImage (for testing purposes), last line of the log is exactly the same:

00:00:09 - SDL Info (0): Dropping window event during flush: 6 (1280 800)
00:00:09 - SDL Info (0): IDR frame request sent
00:00:09 - FFmpeg: [hevc @ 0x7f62fc658800] Output frame with POC 0.
00:00:09 - SDL Info (0): VDPAU surface size: 1280x800
00:00:52 - SDL Info (0): Control stream received unexpected disconnect event
00:00:52 - SDL Error (0): Connection terminated: -1
00:00:52 - SDL Info (0): Quit event received
00:00:52 - SDL Info (0): Failed to send ENet control packet
00:00:52 - SDL Info (0): Loss Stats: Transaction failed: 0
00:00:52 - SDL Info (0): Global video stats
00:00:52 - SDL Info (0): ----------------------------------------------------------
Incoming frame rate from network: 59.44 FPS
Decoding frame rate: 59.44 FPS
Rendering frame rate: 59.07 FPS
Frames dropped by your network connection: 0.00%
Frames dropped due to network jitter: 0.25%
Average network latency: 2 ms (variance: 1 ms)
Average decoding time: 2.24 ms
Average frame queue delay: 0.40 ms
Average rendering time (including monitor V-sync latency): 3.67 ms
00:00:52 - SDL Info (0): Stopping input stream...
00:00:52 - SDL Info (0): done
00:00:52 - SDL Info (0): Stopping audio stream...
00:00:53 - SDL Info (0): done
00:00:53 - SDL Info (0): Stopping video stream...
00:00:53 - Qt Info: Found "gamecontrollerdb.txt" at "/home/deck/.cache/Moonlight Game Streaming Project/Moonlight/gamecontrollerdb.txt"
00:00:53 - SDL Info (0): Loaded 266 new gamepad mappings
00:00:53 - SDL Info (0): done
00:00:53 - SDL Info (0): Stopping control stream...
00:00:53 - SDL Info (0): ENet peer is already disconnected
00:00:53 - SDL Info (0): done
00:00:53 - SDL Info (0): Cleaning up input stream...
00:00:53 - SDL Info (0): done
00:00:53 - SDL Info (0): Cleaning up video stream...
00:00:53 - SDL Info (0): done
00:00:53 - SDL Info (0): Cleaning up control stream...
00:00:53 - SDL Info (0): done
00:00:53 - SDL Info (0): Cleaning up audio stream...
00:00:53 - SDL Info (0): done
00:00:53 - SDL Info (0): Cleaning up platform...
00:00:53 - SDL Info (0): done

@Chris3773 Chris3773 mentioned this issue Mar 31, 2023
Open
@Chris3773
Copy link
Author

The app termination has been updated in Sunshine v.0.20.0 which stops the Moonlight clients from giving a termination error. The PR should still be merged for the client but for now the client process does not stay running during normal use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not show error dialog if quitAfter is set Chris3773/moonlight-qt
2 participants
@bocki @Chris3773