Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configure switches for ALSA, JACK and pulseaudio #254

Closed
domichel opened this issue Oct 26, 2019 · 7 comments
Closed

add configure switches for ALSA, JACK and pulseaudio #254

domichel opened this issue Oct 26, 2019 · 7 comments
Assignees
Milestone

Comments

@domichel
Copy link

domichel commented Oct 26, 2019

It would be great on linux to have configure options for ALSA, JACK and pulseaudio. The reason is simple: as a musician, linux provide JACK as professional grade sound server and pulseaudio is not even installed into my system. I have to patch Makefile.am in order to remove pulse from the build, and it would be much better if it was enable/disable configure switches for that.

--- giada-0.15.4-src/Makefile.am.orig 2019-03-21 22:43:15.000000000 +0100
+++ giada-0.15.4-src/Makefile.am 2019-07-12 17:32:45.585780900 +0200
@@ -369,11 +369,11 @@

if LINUX

-# Add preprocessor flags to enable ALSA, Pulse and JACK in RtAudio.
-cppFlags += -D__LINUX_ALSA__ -D__LINUX_PULSE__ -D__UNIX_JACK__
+# Add preprocessor flags to enable ALSA and JACK in RtAudio.
+cppFlags += -D__LINUX_ALSA__ -D__UNIX_JACK__

ldAdd += -lsndfile -lfltk -lXext -lX11 -lXft -lXpm -lm -ljack -lasound \

  • -lpthread -ldl -lpulse-simple -lpulse -lsamplerate -lrtmidi -ljansson \
  • -lpthread -ldl -lsamplerate -lrtmidi -ljansson
    -lfreetype -lfontconfig -lXrender -lXfixes -lXcursor -lXinerama

endif

@monocasual
Copy link
Collaborator

monocasual commented Oct 27, 2019

Cool idea. Could you please make a pull request for this? Sorry, misread: that's the manual workaround.

Adding --with-pulse, --with-jack and so on shouldn't be a problem.

@monocasual monocasual added this to the 0.16 series milestone Oct 27, 2019
@monocasual monocasual self-assigned this Oct 27, 2019
@domichel
Copy link
Author

domichel commented Oct 28, 2019 via email

@monocasual
Copy link
Collaborator

Sure, actually it's just a matter of defining some preprocessor macros. Specifically: __LINUX_ALSA__, __LINUX_PULSE__ and __UNIX_JACK__.

Currently these macros are hardcoded in the Makefile.am. It's just a matter of mapping new flags such as --with-alsa, --with-pulse , ... to the macros above.

I can take a look at it as soon as all the issues from 0.16.0-beta1 have been closed.

@monocasual monocasual modified the milestones: 0.16.5, 0.16.4, 0.17 series Jun 13, 2020
@monocasual
Copy link
Collaborator

Postponed to 0.17 as this feature depends on #153 .

@monocasual monocasual modified the milestones: 0.17 series, 0.17.1 Oct 2, 2020
@monocasual monocasual removed their assignment Nov 23, 2020
@gvnnz gvnnz self-assigned this Nov 23, 2020
@gvnnz
Copy link
Contributor

gvnnz commented Dec 2, 2020

@gvnnz
Copy link
Contributor

gvnnz commented Jan 30, 2021

Better wait for #315, if PR thestk/rtaudio#251 will get merged. Moving to 0.18.

@gvnnz gvnnz modified the milestones: 0.17.1, 0.18 Jan 30, 2021
@gvnnz
Copy link
Contributor

gvnnz commented Jun 26, 2021

Done in cfcd79c .

@gvnnz gvnnz closed this as completed Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants