Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux key modifier not recognized on tip text #5233

Open
2 tasks done
pasanflo opened this issue Mar 15, 2024 · 2 comments
Open
2 tasks done

Linux key modifier not recognized on tip text #5233

pasanflo opened this issue Mar 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@pasanflo
Copy link

pasanflo commented Mar 15, 2024

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

pasanflo

Account config

{ "theme": "sonokai", "themeLight": "serika", "themeDark": "serika_dark", "autoSwitchTheme": false, "customTheme": false, "customThemeColors": [ "#323437", "#e2b714", "#e2b714", "#646669", "#2c2e31", "#d1d0c5", "#ca4754", "#7e2a33", "#ca4754", "#7e2a33" ], "favThemes": ["sonokai", "cheesecake", "moonlight", "vscode"], "showKeyTips": true, "showLiveWpm": false, "showTimerProgress": true, "smoothCaret": "fast", "quickRestart": "esc", "punctuation": false, "numbers": false, "words": 1, "time": 30, "mode": "custom", "quoteLength": [1], "language": "spanish", "fontSize": 2, "freedomMode": false, "difficulty": "normal", "blindMode": false, "quickEnd": false, "caretStyle": "default", "paceCaretStyle": "default", "flipTestColors": false, "layout": "default", "funbox": "none", "confidenceMode": "off", "indicateTypos": "off", "timerStyle": "bar", "colorfulMode": true, "randomTheme": "off", "timerColor": "main", "timerOpacity": "1", "stopOnError": "off", "showAllLines": false, "keymapMode": "off", "keymapStyle": "staggered", "keymapLegendStyle": "lowercase", "keymapLayout": "qwerty", "keymapShowTopRow": "layout", "fontFamily": "JetBrains_Mono", "smoothLineScroll": true, "alwaysShowDecimalPlaces": true, "alwaysShowWordsHistory": false, "singleListCommandLine": "manual", "capsLockWarning": true, "playSoundOnError": "2", "playSoundOnClick": "off", "soundVolume": "0.5", "startGraphsAtZero": true, "showOutOfFocusWarning": true, "paceCaret": "off", "paceCaretCustomSpeed": 100, "repeatedPace": true, "pageWidth": "100", "accountChart": ["on", "on", "on", "on"], "minWpm": "off", "minWpmCustomSpeed": 100, "highlightMode": "letter", "typingSpeedUnit": "wpm", "ads": "result", "hideExtraLetters": false, "strictSpace": false, "minAcc": "off", "minAccCustom": 90, "showLiveAcc": false, "showLiveBurst": false, "monkey": false, "repeatQuotes": "off", "oppositeShiftMode": "off", "customBackground": "", "customBackgroundSize": "cover", "customBackgroundFilter": [0, 1, 1, 1, 1], "customLayoutfluid": "qwerty#dvorak#colemak", "monkeyPowerLevel": "off", "minBurst": "off", "minBurstCustomSpeed": 100, "burstHeatmap": false, "britishEnglish": true, "lazyMode": false, "showAverage": "off", "tapeMode": "off" }

Current Behavior

The hint text on the settings page doesn't recognize I'm a Linux user and shows me a shortcut that is not working. It is showing me the Windows shortcut (With Ctrl) and it doesn't work on Firefox Linux.

This is because of how the modifier key is being checked (Link to the checker)

Expected Behavior

For Linux users on Gecko-based browsers, the correct tipped shortcut should be Super+Shift+P

For Linux users on Chromium-based browsers, the tipped shortcut should be typed Ctrl/Super+Shift+P, since it works both ways.

Steps To Reproduce

  1. On a Gecko-based web browser (Firefox, e.g.) go to https://monkeytype.com/settings

  2. It is shown that you can access to the settings by typing Ctrl+Shift+P
    image

  3. Type Ctrl+Shift+P

  4. Nothing happens. (It happens when you do Super+Shift+P)

Environment

  • OS: Manjaro Linux 23.1.3
  • Browser: Mozilla Firefox
  • Browser Version: 123.0.1 (64-bit)

Anything else?

I was checking on how they do it on different typescript-based projects so I can fix it myself, this is how Visual Studio Code does it just in case someone finds it useful:

https://github.com/microsoft/vscode/blob/7674d5634504300a295f0b177c3dd54053680181/src/vs/base/common/platform.ts

@pasanflo pasanflo added the bug Something isn't working label Mar 15, 2024
@fehmer
Copy link
Member

fehmer commented Mar 15, 2024

ctrl+shift+p opens private window in firefox on linux and windows. super-shift-p is already assigned to another action on windows.

Maybe we can use a unused shortcut in firefox like
ctrl+shift+n or ctrl+shift+space

@pasanflo
Copy link
Author

pasanflo commented Mar 16, 2024

I think adding different shortcuts depending on browser could be misleading to some users that use different browsers. May I suggest overriding the native Ctrl/Cmd+K as is widely used over the internet to show this kind of command line tool on the web?
(It overrides the native web search)

Examples on websites using this shortcut in similar command lines:

Vue docs - React docs - MDN web docs

Other option could be using Tab and deleting the shortcut shown on the tip that its not working.

I'll be using Tab from now.

Please let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants