Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language: Bangla, Monkeytype cannot recognize characters ড়, য় #4468

Open
2 tasks done
Oymate opened this issue Jul 20, 2023 · 32 comments
Open
2 tasks done

Language: Bangla, Monkeytype cannot recognize characters ড়, য় #4468

Oymate opened this issue Jul 20, 2023 · 32 comments
Labels
bug Something isn't working waiting for update Pull requests or issues that require changes/comments before continuing

Comments

@Oymate
Copy link

Oymate commented Jul 20, 2023

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes, but sometimes it didn't

Account name

sajsajrob

Account config

{"theme":"serika_dark","themeLight":"serika","themeDark":"serika_dark","autoSwitchTheme":false,"customTheme":false,"customThemeColors":["#323437","#e2b714","#e2b714","#646669","#2c2e31","#d1d0c5","#ca4754","#7e2a33","#ca4754","#7e2a33"],"favThemes":[],"showKeyTips":true,"showLiveWpm":false,"showTimerProgress":true,"smoothCaret":"medium","quickRestart":"off","punctuation":false,"numbers":false,"words":50,"time":30,"mode":"time","quoteLength":[1],"language":"bangla","fontSize":1.5,"freedomMode":false,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"default","paceCaretStyle":"default","flipTestColors":false,"layout":"default","funbox":"none","confidenceMode":"off","indicateTypos":"off","timerStyle":"mini","colorfulMode":false,"randomTheme":"off","timerColor":"main","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"off","keymapStyle":"staggered","keymapLegendStyle":"lowercase","keymapLayout":"overrideSync","keymapShowTopRow":"layout","fontFamily":"Roboto_Mono","smoothLineScroll":false,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":false,"singleListCommandLine":"manual","capsLockWarning":true,"playSoundOnError":false,"playSoundOnClick":"off","soundVolume":"0.5","startGraphsAtZero":true,"showOutOfFocusWarning":true,"paceCaret":"off","paceCaretCustomSpeed":100,"repeatedPace":true,"pageWidth":"125","accountChart":["on","on","on"],"minWpm":"off","minWpmCustomSpeed":100,"highlightMode":"letter","alwaysShowCPM":false,"ads":"result","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"showLiveAcc":false,"showLiveBurst":false,"monkey":false,"repeatQuotes":"off","oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1,1],"customLayoutfluid":"qwerty#dvorak#colemak","monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":false,"britishEnglish":false,"lazyMode":false,"showAverage":"off","tapeMode":"off"}

Current Behavior

Monkeytype cannot recognize the letters ড়, য় (maybe even ঢ় though I was not able to get any words that include ঢ়). I believe this happens because it uses some old encoding scheme where ড+় is used, where the correct letter would be ড়.

Expected Behavior

Monkeytype recognizes ড়, ঢ়, য়

Steps To Reproduce

  1. Go to Monkeytype
  2. Switch language to Bangla
  3. Restart words until you get words such as নয়, উড়ন্ত, পড়া, শয়ন, গাঢ় etc.
  4. Try to type these words using Linux i-bus keyboard or Windows Avro phonetic/Jatiyo keyboard.
  5. Monkeytype can't recognize characters

Environment

  • OS:Win 10, PopOS latest
  • Browser:Firefox
  • Browser Version:115.0.2

Anything else?

No response

@Oymate Oymate added the bug Something isn't working label Jul 20, 2023
@Miodec
Copy link
Member

Miodec commented Jul 21, 2023

How do you achieve those characters? Which keys do I press?

@Oymate
Copy link
Author

Oymate commented Jul 21, 2023

If you use Avro, then you can change layout by pressing F12(don't press Shift+Alt messes up keyboard on windows). Then from dropdown you can select phonetic or Jatiyo. If you select jatiyo then press P/Shift+E/Shift+P, to get these letters. On phonetic you have to type phonetically in english. Like নয় is 'noy' followed by space/enter to select dropdown text.

On Linux install Bangla(Bangladesh) Jatiyo Layout and with Windows key+Space switch keyboard and type P/Shift+E/Shift+P.

Or the simplest solution for you, copy paste from unicode block https://symbl.cc/en/unicode/blocks/bengali/#Additional_consonants in additional consonant section.

@Miodec
Copy link
Member

Miodec commented Jul 25, 2023

image
image
image

Which one is best? Which keys do i press then? Which ones are broken?

@Oymate
Copy link
Author

Oymate commented Jul 27, 2023

Can you send screenshot of the first two option in 'Shift' mode? Thanks

@Oymate
Copy link
Author

Oymate commented Jul 27, 2023

BTW, which app are you using? I might be able to give clearer response if I know.

@Miodec
Copy link
Member

Miodec commented Jul 27, 2023

Thats just the MacOS layout selector

@Oymate
Copy link
Author

Oymate commented Jul 27, 2023

Ok, the second layout is MS InScript layout. In order to get ড়,ঢ়,য়

  • Press Alt+Opening Square bracket/third bracket(ড়)
  • Press Alt+Shift+Opening Square bracket/third bracket(ঢ়)
  • Press Shift+?(য়)

@Miodec
Copy link
Member

Miodec commented Jul 27, 2023

So, for some reason calling .normalize() on the gives us this result:
image
Even though it should return a normalized, composed form of a given string (so, without breaking apart the characters)

Then, because of the way monkeytype handles input, these are split into separate elements, and then displayed separately
image

I could add a special case to NOT normalize Bangla characters, but there still exists the issue of the separate characters. Bangla seems to be the only language (that i've encountered so far) that displays different characters (if surrounded by other characters) while not actually modifying them

image

Monkeytype requires splitting characters to provide per character feedback on if the key was pressed correctly or not

image

This honestly might be impossible to fix, unless there exists a font which wil not display these dotted circles:
image

@Miodec Miodec added the stuck We don't know how to proceed with this label Jul 27, 2023
@Oymate
Copy link
Author

Oymate commented Jul 28, 2023

I would like to remind you that কিিি is intended rendering while ক ি ি ি ি ি is not. The reason ড় gets split might be because in previous(like 90's) version of unicode there was no ড়, ড and the fota was combined to get the letter. Subsequent application brought in the character ড়।
When you do implement changes related to this case please give me screenshots as example so I can assure you it is correct.

@Miodec
Copy link
Member

Miodec commented Jul 28, 2023

I understand the separate rendering is not intended. I also said that there is no way around it without completely reworking the website and straight up removing one of the main features (whch is per key highlight)

@Oymate
Copy link
Author

Oymate commented Jul 28, 2023

Actually the per key highlight works as intended and expected for other words and characters.

@Miodec
Copy link
Member

Miodec commented Jul 28, 2023

It doesn't. When you go to zen mode and type anything, no characters get connected.
image

@Oymate
Copy link
Author

Oymate commented Jul 28, 2023

Wait is zen deployed or in testing?

@Miodec
Copy link
Member

Miodec commented Jul 28, 2023

Zen is live

@Oymate
Copy link
Author

Oymate commented Jul 28, 2023

Interesting, it works in normal mode but not zen mode. In normal mode characters after the main letter are highlighted properly while characters before the main letter are not. Is it possible to implement this, page 70 glyph colouring?

@Oymate
Copy link
Author

Oymate commented Jul 28, 2023

If it's not possible to fix these without breaking changes, just implement proper input normalization for ড়,ঢ় and য় , I will forgo Zen mode no problem.

@Miodec
Copy link
Member

Miodec commented Jul 28, 2023

Nevermind, i was wrong. These characters are displayed correctly if you just switch the language to bangla..
image

@Miodec
Copy link
Member

Miodec commented Jul 28, 2023

Alright, well... going full circle, how do i type উড়ন্ত ? Which keys do i press? Because so far i can type ড় and it gets recognised

@Oymate
Copy link
Author

Oymate commented Jul 28, 2023

উড়ন্ত
Shift+G, Alt+[, V, D, L
(v means small v, similar for d and l)

@Miodec
Copy link
Member

Miodec commented Jul 28, 2023

image

Looks to be working correctly for me

@Oymate
Copy link
Author

Oymate commented Jul 28, 2023

Did you use custom text mode? Custom works but not normal typing mode.

@Miodec
Copy link
Member

Miodec commented Jul 28, 2023

Yeah i did. Interesting, let me play around.

@Oymate
Copy link
Author

Oymate commented Jul 28, 2023

Test on Time>Bangla>120s for testing time. Restart until a word with ড়, ঢ়, য়, ঐ, ঔ comes, tell me the word. I will provide the keys than you can type it in with restart.

@mm-crj
Copy link

mm-crj commented Sep 26, 2023

I have the same problem, I couldn't get how you guys fixed it.
image

@Miodec Miodec closed this as completed in d6d9935 Oct 2, 2023
@Miodec Miodec reopened this Oct 2, 2023
@Miodec
Copy link
Member

Miodec commented Oct 2, 2023

I think i found a solution, ill deploy it to the live site later today - please test and let me know.

@Miodec Miodec removed the stuck We don't know how to proceed with this label Oct 3, 2023
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Oct 3, 2023
@mm-crj
Copy link

mm-crj commented Oct 3, 2023

I tested it for the letter 'য়' that works, but I will check the other characters like it and let you know. However, there is another issue that I would like to draw your attention to here.

@mm-crj
Copy link

mm-crj commented Oct 5, 2023

I think it is kind of working, but it detects something after the letter য়. So each time, I have to backspace before typing forward. And it seems to occur in time mode with 60s.

@Miodec
Copy link
Member

Miodec commented Oct 6, 2023

How do you type that problematic letter?

@mm-crj
Copy link

mm-crj commented Oct 6, 2023

I am on ubuntu, I use the Baisakhi layout
image
then its shift+y.

@Miodec
Copy link
Member

Miodec commented Oct 9, 2023

Seems like im getting a different character when pressing shift+y. Which keys is on this layout?

image

@Miodec
Copy link
Member

Miodec commented Oct 9, 2023

য় this one, right? (i think its shift+/)

@Miodec
Copy link
Member

Miodec commented Oct 9, 2023

So, I cant seem to reproduce the issue with this character.

Does it only happen in time mode?
Does it happen when this character appears in the first 200 words of the test? Or only after the first 200?
Does it happen in custom mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

No branches or pull requests

3 participants