Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tape mode + Smooth line scroll + enter #3907

Open
2 tasks done
KorolOrol opened this issue Jan 11, 2023 · 8 comments
Open
2 tasks done

Tape mode + Smooth line scroll + enter #3907

KorolOrol opened this issue Jan 11, 2023 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@KorolOrol
Copy link

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

KorolOrol

Account config

{"theme":"dev","themeLight":"serika","themeDark":"serika_dark","autoSwitchTheme":false,"customTheme":false,"customThemeColors":["#323437","#e2b714","#e2b714","#646669","#2c2e31","#d1d0c5","#ca4754","#7e2a33","#ca4754","#7e2a33"],"favThemes":[],"showKeyTips":true,"showLiveWpm":false,"showTimerProgress":true,"smoothCaret":true,"quickRestart":"off","punctuation":false,"numbers":false,"words":50,"time":60,"mode":"custom","quoteLength":[1],"language":"english","fontSize":1.5,"freedomMode":false,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"default","paceCaretStyle":"default","flipTestColors":false,"layout":"default","funbox":"none","confidenceMode":"off","indicateTypos":"off","timerStyle":"mini","colorfulMode":false,"randomTheme":"off","timerColor":"main","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"off","keymapStyle":"staggered","keymapLegendStyle":"lowercase","keymapLayout":"overrideSync","keymapShowTopRow":"layout","fontFamily":"Cascadia_Code","smoothLineScroll":true,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":false,"singleListCommandLine":"manual","capsLockWarning":true,"playSoundOnError":false,"playSoundOnClick":"off","soundVolume":"0.5","startGraphsAtZero":true,"showOutOfFocusWarning":true,"paceCaret":"off","paceCaretCustomSpeed":100,"repeatedPace":true,"pageWidth":"125","chartAccuracy":false,"chartStyle":"line","minWpm":"off","minWpmCustomSpeed":100,"highlightMode":"letter","alwaysShowCPM":true,"ads":"off","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"showLiveAcc":false,"showLiveBurst":false,"monkey":false,"repeatQuotes":"off","oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1,1],"customLayoutfluid":"qwerty#dvorak#colemak","monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":false,"britishEnglish":false,"lazyMode":false,"showAverage":"off","tapeMode":"letter"}

Current Behavior

When the tape mode is on and enter occurs in the text, the next line appears below the screen and is not visible.
image

Expected Behavior

The next line will follow the previous one, or the previous line will disappear and a new one will appear.

Steps To Reproduce

  1. Tunt "Tape mode" to "letter" or "word"
  2. Turn "Smooth line scroll" to on
  3. Type text with enters.

Environment

  • OS: Windows 11
  • Browser: Microsoft Edge
  • Browser Version: 108.0.1462.76 (Official Build) (64-bit)

Anything else?

No response

@KorolOrol KorolOrol added the bug Something isn't working label Jan 11, 2023
@Miodec
Copy link
Member

Miodec commented Jan 11, 2023

Side effect of the way tape mode is implemented. I could show the next line but it would "stick" to the one above:
Screenshot 2023-01-11 at 13 27 46
Screenshot 2023-01-11 at 13 27 38
Screenshot 2023-01-11 at 13 28 24

Maybe I could only do it if there is a new line in the text, but still, not sure if I like how it looks.

@harshkanjariya
Copy link

harshkanjariya commented May 31, 2023

I want to work on this,
I can make it like this:
Screenshot 2023-05-31 at 10 13 12 AM

@Miodec
Copy link
Member

Miodec commented Jun 1, 2023

I want to work on this, I can make it like this: Screenshot 2023-05-31 at 10 13 12 AM

It doesnt really make sense for the enter character to be there while keeping the text in the same line.

@Ferotiq
Copy link
Member

Ferotiq commented Aug 20, 2023

@Miodec Would it be possible to have the new line but offset it like this? And have it fade in the closer you get like everything else.
image

@Miodec
Copy link
Member

Miodec commented Aug 21, 2023

@Miodec Would it be possible to have the newline but offset it like this? And have the newline fade in the closer you get like everything else. image

This could work. Not sure how difficult it would be to implement.

@harshkanjariya
Copy link

@Miodec i can try, probably easy to implement

@Miodec
Copy link
Member

Miodec commented Aug 22, 2023

@Miodec i can try, probably easy to implement

Alright, assigned.

@ikarofelix
Copy link
Contributor

@Miodec PR ready for review: #4969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants