DynamicWorkerThreadFactory no longer manages max threads #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Management of max thread count is now delegated to the ForkJoinPool itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1588
DynamicWorkerThreadFactorywas previously managingmaxThreadsparameter ofScheduler.forkJoinmanually, instead of passing it to theForkJoinPoolitself. Now this is changed so that only the pool itself is responsible for that.I don't exactly understand why this fixes the problem or why it wasn't done like that from the start. Therefore I'm not sure if I've done the right thing since I'm not fully familiar with nitty-gritty details of
ForkJoinPool.