Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe: Remove Features from Scheduler #1587

Open
alexandru opened this issue Jun 3, 2022 · 0 comments
Open

Maybe: Remove Features from Scheduler #1587

alexandru opened this issue Jun 3, 2022 · 0 comments

Comments

@alexandru
Copy link
Member

We need to remove the [Features] field, as exposed by [Scheduler#features].

This field is meant to query for the features supported by the Scheduler, and currently scheduler implementations can support these features of interest:

  1. “batching mode”, which executes TrampolinedRunnable instances one after another, on the same thread;
  2. “tracing”, which signals that the underlying Scheduler is able to work with Local;

Unfortunately, this is a parametricity violation, aka an implementation leak, which is a bad practice in both OOP and FP.

We need to review the cases in which these feature flags are used, and maybe find a way to remove the need for them.

@alexandru alexandru changed the title Remove Features from Scheduler Maybe: Remove Features from Scheduler Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant