-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(linting): Replace tslint with eslint #46
Conversation
{ | ||
"root": true, | ||
"parser": "@typescript-eslint/parser", | ||
"plugins": [ | ||
"@typescript-eslint" | ||
], | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:@typescript-eslint/recommended" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the default setup from typescript-eslint
.
@@ -3,17 +3,18 @@ | |||
"private": true, | |||
"scripts": { | |||
"postinstall": "lerna bootstrap", | |||
"lint": "lerna run lint", | |||
"lint-specs": "lerna run lint-specs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't set up different rules for spec files, so this isn't needed.
@@ -3,17 +3,18 @@ | |||
"private": true, | |||
"scripts": { | |||
"postinstall": "lerna bootstrap", | |||
"lint": "lerna run lint", | |||
"lint-specs": "lerna run lint-specs", | |||
"lint": "lerna exec -- npm run lint", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this over to use exec
to maintain color and formatting from eslint.
"lerna": "^3.18.3", | ||
"tslint": "^5.20.0", | ||
"typescript": "^3.6.4" | ||
"typescript": "^3.9.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to bump up the TypeScript version to support @typescript-eslint
.
Fixes #44